[COMMIT LOGREPORT] service/all/lib/Lire ImportJob.pm,1.12,1.13 DlfConverterProcess.pm,1.16,1.17

Francis J. Lacoste flacoste at users.sourceforge.net
Tue Jun 21 17:33:45 CEST 2005


Update of /cvsroot/logreport/service/all/lib/Lire
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2979/all/lib/Lire

Modified Files:
	ImportJob.pm DlfConverterProcess.pm 
Log Message:
- No need to set the $time parameter to its default value in every
  methods which pass the parameter.
- Pass $time to log_fh() method.


Index: ImportJob.pm
===================================================================
RCS file: /cvsroot/logreport/service/all/lib/Lire/ImportJob.pm,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- ImportJob.pm	21 Jun 2005 14:57:59 -0000	1.12
+++ ImportJob.pm	21 Jun 2005 15:33:28 -0000	1.13
@@ -294,8 +294,6 @@
 
     check_object_param( $store, 'store', 'Lire::DlfStore' );
 
-    $time ||= time();
-
     my $process = new Lire::DlfConverterProcess( $self, $store );
     $process->run_import_job( $time );
 

Index: DlfConverterProcess.pm
===================================================================
RCS file: /cvsroot/logreport/service/all/lib/Lire/DlfConverterProcess.pm,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- DlfConverterProcess.pm	21 Jun 2005 14:58:00 -0000	1.16
+++ DlfConverterProcess.pm	21 Jun 2005 15:33:28 -0000	1.17
@@ -79,19 +79,18 @@
 sub run_import_job {
     my ( $self, $time ) = @_;
 
-    $time ||= time;
     croak $self->{'_job'}->name(), " ImportJob was already processed"
       if $self->{'_convert_called'};
 
     $self->{'_job_id'} = $self->{'_job'}->name() . '-' .
-      strftime( "%Y%m%d_%H%M%S", localtime $time )
+      strftime( "%Y%m%d_%H%M%S", localtime )
         unless exists $self->{'_job_id'};
 
     $self->{'_time_start'} = time;
     $self->_init_counters();
     $self->_init_converter();
     $self->_init_streams();
-    $self->{'_fh'} = $self->{'_job'}->log_fh();
+    $self->{'_fh'} = $self->{'_job'}->log_fh( $time );
 
     if ( $self->{'_converter'}->handle_log_lines() ) {
         $self->_handle_continuation();

-- 
To UNSUBSCRIBE, email to commit-request at logreport.org with a subject of 
"unsubscribe". Trouble? Send an email with subject "help" to 
commit-request at logreport.org



More information about the Commit mailing list